[asterisk-dev] [Code Review] 2408: Pimp Sip: Video support

[Joshua Colp]

> On March 28, 2013, 12:32 p.m., Joshua Colp wrote:
> > /team/group/pimp_my_sip/channels/chan_gulp.c, line 441
> > <https://reviewboard.asterisk.org/r/2408/diff/4/?file=35064#file35064line441>
> >
> >     This is incorrect. You want to choose a codec based on the channel native formats, since you may have already the choices based on the requested capabilities.

Erm since you may have different choices.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2408/#review8142
-----------------------------------------------------------


On March 27, 2013, 6:40 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2408/
> -----------------------------------------------------------
> 
> (Updated March 27, 2013, 6:40 p.m.)
> 
> 
> Review request for Asterisk Developers and Joshua Colp.
> 
> 
> Bugs: ASTERISK-21077
>     https://issues.asterisk.org/jira/browse/ASTERISK-21077
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds video media handling support to the new SIP work being done in Asterisk.  Similar to audio added res_sip_sdp_video.c to handle sdp media negotiations for video.  Added capabilities support to make sure the correct codecs were being offered.  Also added the ability to handle the video source update control frame and initiate a fast video update request when needed.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/channels/chan_gulp.c 384117 
>   /team/group/pimp_my_sip/include/asterisk/res_sip_session.h 384117 
>   /team/group/pimp_my_sip/res/res_sip_authenticator_digest.c 384117 
>   /team/group/pimp_my_sip/res/res_sip_sdp_audio.c 384117 
>   /team/group/pimp_my_sip/res/res_sip_sdp_media.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip_session.c 384117 
> 
> Diff: https://reviewboard.asterisk.org/r/2408/diff/
> 
> 
> Testing
> -------
> 
> Using two softphones that support video was able to successfully connect, via asterisk, and view video.  Also monitored sip messages to make sure the appropriate media attributes were being propagated.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130328/0fa1145c/attachment.htm>