[asterisk-dev] Asterisk 11.3.0-rc1 and srtp - white noise only

Andrea Suisani sickpig at opinioni.net
Wed Mar 27 11:26:10 CDT 2013


On 03/27/2013 04:36 PM, Matthew Jordan wrote:
> On 03/27/2013 09:45 AM, Andrea Suisani wrote:
>> On 03/27/2013 03:21 PM, Matthew Jordan wrote:
>>> On 03/27/2013 05:58 AM, Andrea Suisani wrote:
>>>> Hi,
>>>>
>>>> i've opened an issue related to this regression report
>>>>
>>>> https://issues.asterisk.org/jira/browse/ASTERISK-21323
>>>>
>>>
>>> As an FYI, we did manage to reproduce this quite easily as well, and
>>> will work the issue for 1.8.21.0-rc2/11.3.0-rc2.
>>
>> perfect !
>>
>>> Thanks for reporting this!
>>
>> thanks to you :)
>>
>
> It appears as if this issue was caused by r378555, which was attempting
> to prevent unprotecting non-RTP packets (STUN, etc.)
>
> A patch is available on the issue for testing. We're verifying that it
> works and still fixes the bug that r378555 was addressing, but some
> independent confirmation would be appreciated :-)

aare you referring to whitenoise_fix.diff?

Index: res/res_rtp_asterisk.c
===================================================================
--- res/res_rtp_asterisk.c	(revision 378555)
+++ res/res_rtp_asterisk.c	(working copy)
@@ -1457,7 +1457,7 @@
  		rtp->passthrough = 0;
  	}

-	if ((*in > 1) && res_srtp && srtp && res_srtp->unprotect(srtp, buf, &len, rtcp) < 0) {
+	if ((*in & 0xC0) && res_srtp && srtp && res_srtp->unprotect(srtp, buf, &len, rtcp) < 0) {
  	   return -1;
  	}






More information about the asterisk-dev mailing list