[asterisk-dev] [Code Review] Move NewCallerid, HangupRequest and SoftHangupRequest to Stasis

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2405/
-----------------------------------------------------------

(Updated March 22, 2013, 3:15 p.m.)


Review request for Asterisk Developers, opticron and Matt Jordan.


Changes
-------

Bit more cleanup, as suggested by opticron


Summary
-------

This patch builds upon the work in https://reviewboard.asterisk.org/r/2381/.

This moves the NewCallerid, HangupRequest and SoftHangupRequest events to be
based off of Stasis events.

HangupRequest and SoftHangupRequest are now ast_channel_blob Stasis messages,
with the cause code as an optional field in the blob.

NewCallerid now simply watches for changes in the callerid information in
channel snapshots, and creates the AMI event appropriately.

Since the original NewCallerid event honored the channelvars setting in
manager.conf, the channel variables configured there had to become a part of the
channel snapshot. These are now a part of every snapshot based event, making the
configuration description "every time a channel-oriented event is emitted" less
of a lie.

There a a few other changes wrapped up in here as well.

When ast_channel_topic() is given NULL for a channel, it returns the
ast_channel_topic_all() topic instead of NULL. This can clean up a lot of NULL
checking we're doing currently.

Additionally, the fields Cause and Cause-txt were removed from the base channel
information and put only on the Hangup events, since those fields are
meaningless outside of a Hangup event.

Oh, yeah, and I removed the pipe-delimiter processing of the channelvars field,
since that's been deprecated forever.


This addresses bug ASTERISK-21096.
    https://issues.asterisk.org/jira/browse/ASTERISK-21096


Diffs (updated)
-----

  /trunk/CHANGES 383612 
  /trunk/include/asterisk/channel.h 383612 
  /trunk/main/channel.c 383612 
  /trunk/main/channel_internal_api.c 383612 
  /trunk/main/manager.c 383612 
  /trunk/main/manager_channels.c 383612 

Diff: https://reviewboard.asterisk.org/r/2405/diff


Testing
-------

Manually verified events looked compatible with original events.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130322/1ff23ecc/attachment-0001.htm>