[asterisk-dev] [Code Review]: SIP Domain, Registrar, and Outbound Registration support.

[Joshua Colp]

> On March 21, 2013, 1:57 p.m., Mark Michelson wrote:
> > /team/group/pimp_my_sip/res/res_sip_outbound_registration.c, lines 86-88
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34741#file34741line86>
> >
> >     I don't believe the distributor will distribute tasks into the threadpool when the event in question is due to an endpoint timer expiring. You'll need to edit this function to push the processing into the threadpool.

Changed.


> On March 21, 2013, 1:57 p.m., Mark Michelson wrote:
> > /team/group/pimp_my_sip/res/res_sip_outbound_registration.c, lines 140-146
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34741#file34741line140>
> >
> >     If a temporal response has a Retry-after header, you should use that as the basis for sending a new registration rather than the state->retry_interval.

Added.


> On March 21, 2013, 1:57 p.m., Mark Michelson wrote:
> > /team/group/pimp_my_sip/res/res_sip_outbound_registration.c, line 168
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34741#file34741line168>
> >
> >     Why do you schedule this to happen a second from now? Why not just push the task into the SIP threadpool directly?

Changed.


> On March 21, 2013, 1:57 p.m., Mark Michelson wrote:
> > /team/group/pimp_my_sip/res/res_sip_outbound_registration.c, line 358
> > <https://reviewboard.asterisk.org/r/2398/diff/1/?file=34741#file34741line358>
> >
> >     One complaint I've heard about chan_sip is that on a reload, we end up blasting out tons of REGISTERs (and other requests, too, but that's not relevant here) all at the same time. It may be a good idea to set the delay here to a random interval between 1 and, say, 10 seconds. That way, registrations will be staggered better than if they all happen one second after reloading.

Changed.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2398/#review8111
-----------------------------------------------------------


On March 18, 2013, 7:23 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2398/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 7:23 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This change adds the following:
> 
> 1. A basic registrar which uses the location API to store/update/delete contacts. It also enforces restrictions as configured on the AOR being registered to.
> 2. Basic outbound registration support.
> 3. Domain support.
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/include/asterisk/res_sip.h 383209 
>   /team/group/pimp_my_sip/res/res_sip/config_domain_aliases.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip/config_transport.c 383209 
>   /team/group/pimp_my_sip/res/res_sip/location.c 383206 
>   /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 383209 
>   /team/group/pimp_my_sip/res/res_sip_endpoint_identifier_user.c 383206 
>   /team/group/pimp_my_sip/res/res_sip_outbound_registration.c PRE-CREATION 
>   /team/group/pimp_my_sip/res/res_sip_registrar.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2398/diff
> 
> 
> Testing
> -------
> 
> Tested outbound unauthenticated registrations to remote servers with automatic refresh and failures
> Tested inbound registrations from devices with all provided configuration options
> Tested calling to registered devices
> Tested configured domain aliases
> Tested inbound calling from devices using domains
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130322/405f1247/attachment-0001.htm>