[asterisk-dev] [Code Review]: Add transfer tests for failed transfers

[opticron]

> On March 21, 2013, 9:21 a.m., Mark Michelson wrote:
> > asterisk/trunk/lib/python/asterisk/BridgeTestCase.py, lines 273-275
> > <https://reviewboard.asterisk.org/r/2407/diff/1/?file=34866#file34866line273>
> >
> >     Why is there a sleep both before and afer the playDTMF?

It is done that way as a safeguard against other code used in conjunction with BridgeTestCase that might use playDTMF in a less safe manner.  This is not so much necessitated by the test suite as by the asterisk core in the UUT which rate-limits incoming DTMF (even though the rate limiting should only really apply to inband DTMF and not other kinds).


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2407/#review8104
-----------------------------------------------------------


On March 20, 2013, 3:46 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2407/
> -----------------------------------------------------------
> 
> (Updated March 20, 2013, 3:46 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Add four transfer tests for cases where blind and attended transfers from caller and callee fail because of a bad extension.
> 
> Added the ability to specify the extension to be dialed for blind and attended transfers executed from BridgeTestCase.
> 
> 
> This addresses bug SWP-5319.
>     https://issues.asterisk.org/jira/browse/SWP-5319
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/BridgeTestCase.py 3669 
>   asterisk/trunk/tests/bridge/tests.yaml 3669 
>   asterisk/trunk/tests/bridge/transfer_failure/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/bridge/transfer_failure/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2407/diff
> 
> 
> Testing
> -------
> 
> Ran it under the test suite and verified that the expected events were occurring via the log files.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130321/a83fcff1/attachment.htm>