[asterisk-dev] [Code Review] Stasis application WebSocket support

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2361/#review8101
-----------------------------------------------------------



/trunk/apps/app_stasis.c
<https://reviewboard.asterisk.org/r/2361/#comment15551>

    Drop the "__".



/trunk/apps/app_stasis.c
<https://reviewboard.asterisk.org/r/2361/#comment15552>

    These ref-bumping accessors are unnecessary since the containers are only created and have their final unref on module load and unload.



/trunk/apps/app_stasis.c
<https://reviewboard.asterisk.org/r/2361/#comment15556>

    There are multiple different local symbols in this review named "stasis_app" which could be confusing and they should not match stasis_* which denotes global symbols.



/trunk/apps/app_stasis.c
<https://reviewboard.asterisk.org/r/2361/#comment15553>

    msg needs a null check.



/trunk/apps/app_stasis.c
<https://reviewboard.asterisk.org/r/2361/#comment15554>

    Idem.



/trunk/res/res_stasis_websocket.c
<https://reviewboard.asterisk.org/r/2361/#comment15560>

    This is the other stasis_app.



/trunk/res/res_stasis_websocket.c
<https://reviewboard.asterisk.org/r/2361/#comment15564>

    This error message is also applicable in several other places, but is unnecessary.


- opticron


On March 18, 2013, 12:47 p.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2361/
> -----------------------------------------------------------
> 
> (Updated March 18, 2013, 12:47 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This patch is based on the stasis-core message bus, in
> https://reviewboard.asterisk.org/r/2339/
> 
> This is the API that binds the Stasis dialplan application to external
> Stasis applications. It also adds the beginnings of WebSocket
> application support.
> 
> This module registers a dialplan function named Stasis, which is used
> to put a channel into the named Stasis app. As a channel enters and
> leaves the Stasis diaplan applcation, the Stasis app receives a
> 'stasis-start' and 'stasis-end' events.
> 
> Stasis apps register themselves using the stasis_app_register and
> stasis_app_unregister functions. Messages are sent to an appliction
> using stasis_app_send.
> 
> Finally, Stasis apps control channels through the use of the
> stasis_app_control object, and the family of stasis_app_control_*
> functions.
> 
> The biggest unknown I have about this patch is how I'm exporting
> symbols from app_stasis.so. I believe I'm doing it correctly, and they
> should not need to use optional API. If anyone knows if it will be a
> problem on BSD, Solaris, etc., please let me know.
> 
> Other changes along for the ride are:
>  * An ast_frame_dtor function that's RAII_VAR safe
>  * Some common JSON encoders for name/number, timeval, and
>    context/extension/priority
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/Makefile 383287 
>   /trunk/apps/app_stasis.c PRE-CREATION 
>   /trunk/apps/app_stasis.exports.in PRE-CREATION 
>   /trunk/apps/stasis_json.c PRE-CREATION 
>   /trunk/include/asterisk/app_stasis.h PRE-CREATION 
>   /trunk/include/asterisk/frame.h 383287 
>   /trunk/include/asterisk/json.h 383287 
>   /trunk/include/asterisk/localtime.h 383287 
>   /trunk/main/frame.c 383287 
>   /trunk/res/res_json.c 383287 
>   /trunk/res/res_stasis_websocket.c PRE-CREATION 
>   /trunk/tests/test_abstract_jb.c 383287 
>   /trunk/tests/test_app_stasis.c PRE-CREATION 
>   /trunk/tests/test_json.c 383287 
> 
> Diff: https://reviewboard.asterisk.org/r/2361/diff
> 
> 
> Testing
> -------
> 
> Unit tests; ran a few channels through the applications
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130321/66411695/attachment-0001.htm>