[asterisk-dev] [Code Review] Allow running test suite locally - initial work

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2371/#review8098
-----------------------------------------------------------


I like the idea. It could use some tweaking still.


/asterisk/trunk/README.txt
<https://reviewboard.asterisk.org/r/2371/#comment15545>

    I'd prefer run-local, not run_local. The other files use a dash too.



/asterisk/trunk/lib/python/asterisk/asterisk.py
<https://reviewboard.asterisk.org/r/2371/#comment15547>

    This is hard to read and wrong.
    (1) AST_TEST_ROOT was always ''
    (2) test_suite_root is now always /tmp instead of /tmp/ast_test_XXX/tmp.
    
    As for the asterisk_etc_directory. I'm not sure why it has to be specified. We're guessing the location below anyway..
    
    I'd rather remove the ``asterisk_etc_directory`` setting here and set it to os.path.dirname(c) after the guess.



/asterisk/trunk/run_local
<https://reviewboard.asterisk.org/r/2371/#comment15548>

    You're forcing me into naming the testsuite /testsuite/, while it doesn't need to.
    
    Wouldn't this be nicer?
    
      ASTROOT=~/astroots/1.8.x ./run_local setup 
      ASTROOT=~/astroots/1.8.x ./run_local run
    
    Then we wouldn't need a random tmpname, but could have /tmp/ast_test_1.8.x instead.



/asterisk/trunk/run_local
<https://reviewboard.asterisk.org/r/2371/#comment15546>

    This is empty. mktemp_symlink doesn't echo anything. So the RM below does nothing.
    
    And it wouldn't be reached if ./runtests.py returned false.
    
    And we don't like that things are removed. The original tests keep the structure around so we can asterisk -C in a testdir after running it.


- wdoekes


On March 7, 2013, 12:28 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2371/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 12:28 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Place anything needed for the test suite (except the actual sources of Asterisk) under the test suite directory.
> 
> Fix parts in the python code. Add a wrapper script (run_local) for the required automation.
> 
> Work is still needed on asttest (add a destdir option? Consolidate all the run-test scripts to run it through a common function?) but I'm not exactly sure how the information is passed to Lua.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/README.txt 3660 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 3660 
>   /asterisk/trunk/run_local PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2371/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130321/d4b3942a/attachment.htm>