[asterisk-dev] [Code Review] testsuite: when mirroring the asterisk dirs, don't trip over broken symlinks

wdoekes reviewboard at asterisk.org
Mon Mar 18 03:51:37 CDT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2395/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

Hi,

the os.path.exists() check returns False when a broken symlink is read while doing the Asterisk.__mirror_dir creating. Use os.path.lexists() instead.

Reproduce:

  place a broken symlink in /var/lib/asterisk and watch all tests fail


Diffs
-----

  /asterisk/trunk/lib/python/asterisk/asterisk.py 3668 

Diff: https://reviewboard.asterisk.org/r/2395/diff


Testing
-------

After the patch, the tests don't fail.


Thanks,

wdoekes

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130318/ba8cc830/attachment.htm>


More information about the asterisk-dev mailing list