[asterisk-dev] [Code Review] Reduce the number of bridging threading models to just one.

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2391/
-----------------------------------------------------------

Review request for Asterisk Developers.


Summary
-------

This review is to get a sanity check on the bridging architecture to see if I am going in the right direction.  It is probably best to look at the bridging files as a whole rather than just looking at the diff in the review.

High level overview of the bridging module objects.

Bridge-manager: This thread handles odd jobs for all bridges in the system.  The manager has a service request queue that tells it to see what needs doing to a bridge.

Bridge: The bridge object does not have a thread associated with it.  It simply directs where a bridge channel thread should put frames written into the bridge.  The bridge has an action queue for general bridge servicing.  The only actions currently posted to the queue are deferred destruction of the softmix bridge private structure.

Bridge-channel: The bridge channel component of a bridge has a thread associated with it that services the reads and writes between the channel and the bridge.  The thread also performs any actions to the channel such as playing a file or running the connected line interception routines.

Bridge-technology: The bridge technology component of a bridge gives the bridge its basic characteristics for how media passes through the bridge.  The current technologies implemented are holding (For parking calls), simple two party, softmix (For multiparty like ConfBridge).


This addresses bug ASTERISK-21052.
    https://issues.asterisk.org/jira/browse/ASTERISK-21052


Diffs
-----

  /team/group/bridge_construction/bridges/bridge_holding.c 383119 
  /team/group/bridge_construction/bridges/bridge_multiplexed.c 383119 
  /team/group/bridge_construction/bridges/bridge_simple.c 383119 
  /team/group/bridge_construction/bridges/bridge_softmix.c 383119 
  /team/group/bridge_construction/include/asterisk/bridging.h 383119 
  /team/group/bridge_construction/include/asterisk/bridging_features.h 383119 
  /team/group/bridge_construction/include/asterisk/bridging_technology.h 383119 
  /team/group/bridge_construction/main/asterisk.c 383119 
  /team/group/bridge_construction/main/bridging.c 383119 

Diff: https://reviewboard.asterisk.org/r/2391/diff


Testing
-------

Basic calls
Current DTMF blind/attended transfers (They are not fully feature complete).  The attended transfer does have the ability to convert the call to a three way call.


Thanks,

rmudgett

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130315/ab056827/attachment-0001.htm>