[asterisk-dev] [Code Review] Refactor Dialing to publish Stasis-Core messages

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2383/#review8058
-----------------------------------------------------------



/trunk/apps/app_dial.c
<https://reviewboard.asterisk.org/r/2383/#comment15484>

    Putting this primitive function early in the source file eliminates the need for the prototype.



/trunk/main/channel.c
<https://reviewboard.asterisk.org/r/2383/#comment15485>

    This check is not needed.  There is no way for the ao2 destructor to be called with this NULL.


- rmudgett


On March 13, 2013, 12:03 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2383/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 12:03 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Summary
> -------
> 
> As part of the CDR work for Asterisk 12 (see https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+CDR+Specification), we need Dial information published over Stasis-Core. This patch refactors app_dial to publish the necessary events.
> 
> The Dial based events are slightly different in Asterisk 12 than in other previous versions:
>  * Dial is now two events, DialBegin and DialEnd. This matches the nomenclature of other AMI events. See https://wiki.asterisk.org/wiki/display/AST/AMI+1.4+Specification for more information.
>  * Dial events now occur at the beginning of a dial operation and when the status of the dial operation is known. Previously, it occurred on application exit, which occurred after bridging.
> 
> Note that other applications will need refactoring as well (such as the Dial Framework, Queue, FollowMe, etc.) - however, in order to limit the scope of the work, I've kept it only to app_dial at this point.
> 
> 
> This addresses bug ASTERISK-21196.
>     https://issues.asterisk.org/jira/browse/ASTERISK-21196
> 
> 
> Diffs
> -----
> 
>   /trunk/main/features.c 383007 
>   /trunk/main/manager.c 383007 
>   /trunk/main/channel.c 383007 
>   /trunk/include/asterisk/channel.h 383007 
>   /trunk/apps/app_dial.c 383007 
> 
> Diff: https://reviewboard.asterisk.org/r/2383/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130314/cd3bf691/attachment.htm>