[asterisk-dev] [Code Review]: Transition MWI events to Stasis

[opticron]

> On March 14, 2013, 12:13 p.m., David Lee wrote:
> > team/dlee/stasis-core/channels/chan_dahdi.c, lines 505-510
> > <https://reviewboard.asterisk.org/r/2368/diff/5/?file=34089#file34089line505>
> >
> >     The way stasis caching works, I don't think the no-op subscription is actually necessary.

The no-op subscription is necessary for voicemail's pollmailboxes.


> On March 14, 2013, 12:13 p.m., David Lee wrote:
> > team/dlee/stasis-core/channels/chan_iax2.c, lines 1319-1324
> > <https://reviewboard.asterisk.org/r/2368/diff/5/?file=34090#file34090line1319>
> >
> >     Ditto on the unnecessary comment.

Same.


> On March 14, 2013, 12:13 p.m., David Lee wrote:
> > team/dlee/stasis-core/channels/chan_mgcp.c, lines 487-493
> > <https://reviewboard.asterisk.org/r/2368/diff/5/?file=34091#file34091line487>
> >
> >     Ditto on the unnecessary comment.

Same.


> On March 14, 2013, 12:13 p.m., David Lee wrote:
> > team/dlee/stasis-core/main/app.c, lines 2691-2693
> > <https://reviewboard.asterisk.org/r/2368/diff/5/?file=34100#file34100line2691>
> >
> >     The container should be locked to avoid race conditions building two topics at the same time.

Done.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2368/#review8049
-----------------------------------------------------------


On March 14, 2013, 1:49 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2368/
> -----------------------------------------------------------
> 
> (Updated March 14, 2013, 1:49 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Summary
> -------
> 
> This converts the usage of the existing event system in Asterisk for MWI to use Stasis as the pubsub backend.
> 
> Note: This patch requires the changes in https://reviewboard.asterisk.org/r/2367/ to compile.
> 
> 
> This addresses bug ASTERISK-21097.
>     https://issues.asterisk.org/jira/browse/ASTERISK-21097
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_minivm.c 383038 
>   trunk/apps/app_voicemail.c 383038 
>   trunk/channels/chan_dahdi.c 383038 
>   trunk/channels/chan_iax2.c 383038 
>   trunk/channels/chan_mgcp.c 383038 
>   trunk/channels/chan_sip.c 383038 
>   trunk/channels/chan_skinny.c 383038 
>   trunk/channels/chan_unistim.c 383038 
>   trunk/channels/sig_pri.h 383038 
>   trunk/channels/sig_pri.c 383038 
>   trunk/channels/sip/include/sip.h 383038 
>   trunk/include/asterisk/app.h 383038 
>   trunk/include/asterisk/xmpp.h 383038 
>   trunk/main/app.c 383038 
>   trunk/main/asterisk.c 383038 
>   trunk/res/res_jabber.c 383038 
>   trunk/res/res_xmpp.c 383038 
> 
> Diff: https://reviewboard.asterisk.org/r/2368/diff
> 
> 
> Testing
> -------
> 
> MWI distribution to SIP phones has been tested manually as has the pollmailboxes option for voicemail.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130314/e64cc51a/attachment-0001.htm>