[asterisk-dev] [Code Review] Transition Device State usage to Stasis

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2389/#review8053
-----------------------------------------------------------


With the advent of Stasis, it becomes trivial to write unit tests that push Stasis messages through and test application logic that depends on those messages. While MWI is relatively straight forward, device state is not.

In particular, it feels like we could have unit tests that check device state caching, aggregation (both completely internal as well as internal/external), and subscription for internal/external device states.


- Matt


On March 14, 2013, 1:48 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2389/
> -----------------------------------------------------------
> 
> (Updated March 14, 2013, 1:48 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> In the move from Asterisk's event system to Stasis, this makes distributed device state aggregation always-on, removes unnecessary task processors where possible, and collapses aggregate and non-aggregate states into a single cache for ease of retrieval. This also removes an intermediary step in device state aggregation.
> 
> 
> This addresses bug ASTERISK-21101.
>     https://issues.asterisk.org/jira/browse/ASTERISK-21101
> 
> 
> Diffs
> -----
> 
>   trunk/apps/app_queue.c 383038 
>   trunk/include/asterisk/devicestate.h 383038 
>   trunk/include/asterisk/xmpp.h 383038 
>   trunk/main/asterisk.c 383038 
>   trunk/main/ccss.c 383038 
>   trunk/main/devicestate.c 383038 
>   trunk/main/pbx.c 383038 
>   trunk/res/res_jabber.c 383038 
>   trunk/res/res_xmpp.c 383038 
> 
> Diff: https://reviewboard.asterisk.org/r/2389/diff
> 
> 
> Testing
> -------
> 
> This change was run against the queue integration tests, the generic_ccss test, the device_state_notification test, and the non_digium_state_change test with no ill effects.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130314/edb89b6e/attachment.htm>