[asterisk-dev] [Code Review] Move Newexten and UserEvent AMI events to Stasis; adding JSON messages to stasis-core

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2381/
-----------------------------------------------------------

(Updated March 14, 2013, 11:07 a.m.)


Review request for Asterisk Developers.


Changes
-------

Added json.c and manager_channels.c, which were left out of prior diff.


Summary
-------

This patch started out simply as fixing the bouncing tests introduced
in r382685, but required some other changes to give it a decent
implementation.

To fix the bouncing tests, the UserEvent and Newexten AMI events
needed to be refactored to dispatch via Stasis. Dispatching directly
to AMI resulted in those events sometimes getting ahead of the
associated Newchannel events, which would understandably confuse anyone.

I found that instead of creating a zillion different message types and
structures associated with them, it would be preferable to define a
message type that has a channel snapshot and a blob of structured data
with a small bit of additional information. The JSON object model
provides a very nice way of representing structured data, so I went
with that.

 * Move JSON support from res_json.c to main/json.c
   * Made libjansson-dev a required dependency
 * Added an ast_channel_blob message type, which has a channel
   snapshot and JSON blob of data.
 * Changed UserEvent and Newexten events so that they are dispatched
   via ast_channel_blob messages on the channel's topic.
 * Got rid of the ast_channel_varset message; used ast_channel_blob
   instead.
 * Extracted the manager functions converting Stasis channel events to
   AMI events into manager_channel.c.


Diffs (updated)
-----

  /trunk/main/json.c PRE-CREATION 
  /trunk/main/manager.c 382826 
  /trunk/main/channel.c 382826 
  /trunk/configure.ac 382826 
  /trunk/include/asterisk/autoconfig.h.in 382826 
  /trunk/include/asterisk/channel.h 382826 
  /trunk/include/asterisk/manager.h 382826 
  /trunk/configure 382826 
  /trunk/apps/app_userevent.c 382826 
  /trunk/main/manager_channels.c PRE-CREATION 
  /trunk/main/pbx.c 382826 
  /trunk/pbx/pbx_realtime.c 382826 
  /trunk/res/res_json.c 382826 
  /trunk/res/res_json.exports.in 382826 
  /trunk/tests/test_json.c 382826 

Diff: https://reviewboard.asterisk.org/r/2381/diff


Testing
-------

Ran bouncing testsuite tests 10 times without failure.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130314/6e0fec24/attachment.htm>