[asterisk-dev] [Code Review] Add message cache dumping to Stasis

David Lee reviewboard at asterisk.org
Thu Mar 7 16:04:56 CST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2367/#review8018
-----------------------------------------------------------

Ship it!


Looks good!

- David


On March 7, 2013, 4:03 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2367/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 4:03 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Summary
> -------
> 
> Things in this review:
> * Creation of cache dump capability
> ** Returns an ao2_container with the requested items
> * Update of the Stasis unit tests to cover cache dumping
> 
> 
> This addresses bug ASTERISK-21097.
>     https://issues.asterisk.org/jira/browse/ASTERISK-21097
> 
> 
> Diffs
> -----
> 
>   team/dlee/stasis-core/include/asterisk/stasis.h 382648 
>   team/dlee/stasis-core/main/stasis_cache.c 382648 
>   team/dlee/stasis-core/tests/test_stasis.c 382648 
> 
> Diff: https://reviewboard.asterisk.org/r/2367/diff
> 
> 
> Testing
> -------
> 
> Tested this using the unit tests and in conjunction with the MWI changes they were created for.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130307/7d0daadb/attachment.htm>


More information about the asterisk-dev mailing list