[asterisk-dev] [Code Review]: Allow running test suite locally - initial work

[Tzafrir Cohen]

> On March 6, 2013, 1:39 p.m., Paul Belanger wrote:
> > /asterisk/trunk/lib/python/asterisk/asterisk.py, line 166
> > <https://reviewboard.asterisk.org/r/2371/diff/1/?file=33882#file33882line166>
> >
> >     I don't think this actually will work as you expect.  We initial did this at the beginning but started to see filename get truncated due to the length of patch names.
> 
> Paul Belanger wrote:
>     path*
> 
> Paul Belanger wrote:
>     http://svnview.digium.com/svn/testsuite?view=revision&revision=263

Using the hard-wired path /tmp/asterisk-testsuite is wrong. What happens if we want to run two test-suites on the same system?

So we should use mktemp to create a temporary directory instead. But we need to tell everyone to use that directory, right?

So let's use a symlink under /tmp instead, and link it to the directory created in this patch. The generated patch will be even slightly shorter. Let's just hope we won't run into the limit of 8 symlinks in our symlink forest :-)


- Tzafrir


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2371/#review7999
-----------------------------------------------------------


On March 6, 2013, 12:42 p.m., Tzafrir Cohen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2371/
> -----------------------------------------------------------
> 
> (Updated March 6, 2013, 12:42 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Place anything needed for the test suite (except the actual sources of Asterisk) under the test suite directory.
> 
> Fix parts in the python code. Add a wrapper script (run_local) for the required automation.
> 
> Work is still needed on asttest (add a destdir option? Consolidate all the run-test scripts to run it through a common function?) but I'm not exactly sure how the information is passed to Lua.
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/lib/python/asterisk/asterisk.py 3660 
>   /asterisk/trunk/run_local PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2371/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Tzafrir
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130307/51b7147e/attachment.htm>