[asterisk-dev] [Code Review] 2647: ARI: Implement channel hold/unhold

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2647/#review9022
-----------------------------------------------------------

Ship it!


I would say that adding explicit music class can be added later. This looks good for now.

- David Lee


On June 27, 2013, 12:56 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2647/
> -----------------------------------------------------------
> 
> (Updated June 27, 2013, 12:56 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21619
>     https://issues.asterisk.org/jira/browse/ASTERISK-21619
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This puts the channel on (or removes the channel from) hold.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis_app.h 393056 
>   /trunk/res/stasis/control.c 393056 
>   /trunk/res/stasis_http/resource_channels.c 393056 
> 
> Diff: https://reviewboard.asterisk.org/r/2647/diff/
> 
> 
> Testing
> -------
> 
> The indication gets to the channel driver - MoH starts and stops.  Not a heck of a lot to test here.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130628/b98ef19b/attachment-0001.htm>