[asterisk-dev] [Code Review] 2631: Move channel driver registry events to stasis.

[David Lee]

> On June 27, 2013, 11:09 a.m., Joshua Colp wrote:
> > /trunk/main/manager_system.c, lines 70-102
> > <https://reviewboard.asterisk.org/r/2631/diff/3/?file=40504#file40504line70>
> >
> >     This should be rewritten to use the new to_ami callback mechanism, and forwarded to the manager topic.

Agreed. Patch looks good, otherwise.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2631/#review8990
-----------------------------------------------------------


On June 27, 2013, 11:06 a.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2631/
> -----------------------------------------------------------
> 
> (Updated June 27, 2013, 11:06 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21488
>     https://issues.asterisk.org/jira/browse/ASTERISK-21488
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This also does a bit of shuffling of ast_system_topic(), since more stuff uses it now.
> 
> Note that events have not been added to res_sip_outbound_registration.  Those can come later, if desired.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_iax2.c 393055 
>   /trunk/channels/chan_sip.c 393055 
>   /trunk/include/asterisk.h 393055 
>   /trunk/include/asterisk/manager.h 393055 
>   /trunk/include/asterisk/stasis_system.h PRE-CREATION 
>   /trunk/main/asterisk.c 393055 
>   /trunk/main/file.c 393055 
>   /trunk/main/manager.c 393055 
>   /trunk/main/manager_system.c PRE-CREATION 
>   /trunk/main/sounds_index.c 393055 
>   /trunk/main/stasis_system.c PRE-CREATION 
>   /trunk/res/res_stun_monitor.c 393055 
> 
> Diff: https://reviewboard.asterisk.org/r/2631/diff/
> 
> 
> Testing
> -------
> 
> The events come out...
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130628/2b89af9d/attachment-0001.htm>