[asterisk-dev] [Code Review] 2648: func_channel: set dtmf_features

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2648/#review9008
-----------------------------------------------------------



/trunk/funcs/func_channel.c
<https://reviewboard.asterisk.org/r/2648/#comment17713>

    Why case insensitive? Features for Dial have always been case sensitive and having them different could cause confusion.



/trunk/funcs/func_channel.c
<https://reviewboard.asterisk.org/r/2648/#comment17714>

    I think failures should bubble up to func_channel.



/trunk/main/bridging_basic.c
<https://reviewboard.asterisk.org/r/2648/#comment17709>

    Misnamed I'd say...



/trunk/main/bridging_basic.c
<https://reviewboard.asterisk.org/r/2648/#comment17712>

    if (raise



/trunk/main/bridging_basic.c
<https://reviewboard.asterisk.org/r/2648/#comment17715>

    I'm torn these days on being tolerant of invalid configurations. In this case the user mistyped or thinks a feature exists that doesn't and the end result behavior will differ from what they expect... if a failure gets passed all the way back up, they'll notice it immediately.


- Joshua Colp


On June 27, 2013, 11:14 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2648/
> -----------------------------------------------------------
> 
> (Updated June 27, 2013, 11:14 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21876
>     https://issues.asterisk.org/jira/browse/ASTERISK-21876
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Allows setting dtmf features via a channel set function (namely CHANNEL(dtmf_features)
> 
> 
> Diffs
> -----
> 
>   /trunk/funcs/func_channel.c 393075 
>   /trunk/include/asterisk/bridging_basic.h 393075 
>   /trunk/main/bridging_basic.c 393075 
> 
> Diff: https://reviewboard.asterisk.org/r/2648/diff/
> 
> 
> Testing
> -------
> 
> Stuck two channels in the following extension:
> 
> exten => 10,1,NoOp
> exten => 10,n,Answer()
> exten => 10,n,Set(CHANNEL(dtmf_features)=wktx)
> exten => 10,n,Wait(50)
> 
> Then bridged them together with the manager bridge command and checked to see if both channels could park, transfer, and attended transfer.
> 
> It's worth noting that the dial application overrides this datastore entirely, so these don't get applied to dial as-is. This might need to be addressed.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130628/545e168f/attachment-0001.htm>