[asterisk-dev] [Code Review] 2592: testsuite: Create a basic test for call pickup
jrose
reviewboard at asterisk.org
Thu Jun 27 15:56:41 CDT 2013
> On June 27, 2013, 6:57 p.m., opticron wrote:
> > /asterisk/trunk/tests/feature_call_pickup/run-test, line 11
> > <https://reviewboard.asterisk.org/r/2592/diff/3/?file=40409#file40409line11>
> >
> > Unused import.
removed
- jrose
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2592/#review9001
-----------------------------------------------------------
On June 25, 2013, 10:05 p.m., jrose wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2592/
> -----------------------------------------------------------
>
> (Updated June 25, 2013, 10:05 p.m.)
>
>
> Review request for Asterisk Developers, kmoore and Matt Jordan.
>
>
> Bugs: ASTERISK-21544
> https://issues.asterisk.org/jira/browse/ASTERISK-21544
>
>
> Repository: testsuite
>
>
> Description
> -------
>
> This test is based roughly on the directed pickup application test (but that test doesn't really work anymore). Basically it does the following:
>
> 1) A local channel is originated to an extension that will dial a SIP peer (faker). This SIP peer points to an unused address, so it won't answer.
> 2) Once the dial starts, Asterisk 2 dials Asterisk 1 via SIP to extension *8 (the pickup extension assigned in features.conf)
> 3) At this point the SIP channel on Asterisk 2 (sip_receive is its peername on Asterisk 1) should answer the call made by the local channel since faker is in a callgroup set for use by sip_receive. Both channels will then enter a simple bridge together.
>
> Once https://reviewboard.asterisk.org/r/2582/ is committed I can also add the pickupsound being played as a condition for completing the test.
>
>
> Diffs
> -----
>
> /asterisk/trunk/tests/feature_call_pickup/configs/ast1/extensions.conf PRE-CREATION
> /asterisk/trunk/tests/feature_call_pickup/configs/ast1/features.conf PRE-CREATION
> /asterisk/trunk/tests/feature_call_pickup/configs/ast1/sip.conf PRE-CREATION
> /asterisk/trunk/tests/feature_call_pickup/configs/ast2/extensions.conf PRE-CREATION
> /asterisk/trunk/tests/feature_call_pickup/configs/ast2/sip.conf PRE-CREATION
> /asterisk/trunk/tests/feature_call_pickup/run-test PRE-CREATION
> /asterisk/trunk/tests/feature_call_pickup/test-config.yaml PRE-CREATION
> /asterisk/trunk/tests/tests.yaml 3820
>
> Diff: https://reviewboard.asterisk.org/r/2592/diff/
>
>
> Testing
> -------
>
> Ran it a few times and made sure what was happening matched with log messages after the test was over. Made sure all pass conditions were actually met as well.
>
>
> Thanks,
>
> jrose
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130627/c08db39e/attachment.htm>
More information about the asterisk-dev
mailing list