[asterisk-dev] [Code Review] 2638: res_parking: Gut parker snapshots and replace them with ParkerDialString

[jrose]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2638/
-----------------------------------------------------------

(Updated June 27, 2013, 8:51 p.m.)


Review request for Asterisk Developers, Matt Jordan and rmudgett.


Changes
-------

Hit Matt's review. Updated the review to included changes that have been made to trunk since the review was last posted.


Bugs: ASTERISK-21877
    https://issues.asterisk.org/jira/browse/ASTERISK-21877


Repository: Asterisk


Description
-------

We decided parker snapshots were misleading and unuseful for all but a few uses of parked call messages and events. As such, they've been replaced with just having parker dial strings for handling call control on timeout.

If a channel directly parks another channel, then setting the park dial string is fairly trivial.  We just use the copy the name of the channel that parked the call and then flatten it while creating the parked user. If the call was transferred to the park application somehow, then it must be read from either the BLINDTRANSFER variable or from the newly added ATTENDEDTRANSFER variable which is basically just the BLINDTRANSFER variable for attended transfers.

This effectively wipes out one of the bug bug comments mentioned in ASTERISK-21877 regarding not having a snapshot of who parked the call on so-called 'deep parks' where a park application is deeper than the first priority of the extension a call is transferred to. The other bug bug comment remains at large, but mmichelson has a patch for bridge roles in the works which should make fixing that trivial.


Diffs (updated)
-----

  /trunk/bridges/bridge_builtin_features.c 393053 
  /trunk/include/asterisk/channel.h 393053 
  /trunk/include/asterisk/parking.h 393053 
  /trunk/main/bridging.c 393053 
  /trunk/main/cel.c 393053 
  /trunk/main/channel.c 393053 
  /trunk/main/features.c 393053 
  /trunk/main/parking.c 393053 
  /trunk/res/parking/parking_applications.c 393053 
  /trunk/res/parking/parking_bridge.c 393053 
  /trunk/res/parking/parking_bridge_features.c 393053 
  /trunk/res/parking/parking_controller.c 393053 
  /trunk/res/parking/parking_manager.c 393053 
  /trunk/res/parking/parking_ui.c 393053 
  /trunk/res/parking/res_parking.h 393053 

Diff: https://reviewboard.asterisk.org/r/2638/diff/


Testing
-------

All kinds of different transfers (DTMF blind, DTMF attended, SIP blind, SIP attended, SIP attended with hangups before park, etc).

The only noteworthy case where the parker was anything other than who transferred the call was the following:

SIP/A calls SIP/B
SIP/A performs attended transfer to extension f

f,1,NoOp
f,2,Wait(10)
f,3,Park()

SIP/A hangs up during the wait

This causes the park dial string for SIP/B's parked user to be SIP/B unfortunately, but this is more of a transfer related issue than a parking related issue.  It's also one that Richard says was also the case in previous versions, so this isn't a change in behavior.

This could be addressed by setting the ATTENDEDTRANSFER variable when the masquerade occurs to put B in the PBX where A leaves off.


Thanks,

jrose

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130627/6b175cb7/attachment.htm>