[asterisk-dev] [Code Review] 2645: Use stasis cache in more places

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2645/#review8998
-----------------------------------------------------------



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/2645/#comment17696>

    built needs to be checked for NULL and could make use of RAII_VAR.



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/2645/#comment17699>

    Move this up into the for loop like you have in action_coreshowchannels()



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/2645/#comment17698>

    This iterator is never destroyed.



/trunk/main/manager.c
<https://reviewboard.asterisk.org/r/2645/#comment17697>

    Idem.



/trunk/main/manager_bridging.c
<https://reviewboard.asterisk.org/r/2645/#comment17701>

    You'll need to update some amount of XML documentation with the changes here, but it shouldn't be too excessive.



/trunk/main/manager_channels.c
<https://reviewboard.asterisk.org/r/2645/#comment17700>

    Be warned that changing this function means updating a hefty amount of XML documentation.
    
    For the use case in this review, it's perfectly acceptable to use this function unmodified and add more parameters from the snapshot on a case-by-case basis.


- opticron


On June 26, 2013, 9:09 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2645/
> -----------------------------------------------------------
> 
> (Updated June 26, 2013, 9:09 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21883
>     https://issues.asterisk.org/jira/browse/ASTERISK-21883
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change moves CLI/AGI/AMI commands to accessing the Stasis cache for retrieving information instead of directly accessing the data structures. I have also added an AMI action to get bridge information, and extended the "status" action to include the same information available as "core show channel".
> 
> Stuff given up:
> 1. Number of frames being read and written
> 2. First file descriptor
> 3. What the channel is blocked in
> 
> An additional question:
> I'm not currently storing channel trace information in the snapshot and as a result it is not displayed. Is this a feature we still want to support? How widespread is it?
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/channel.h 392949 
>   /trunk/include/asterisk/stasis_channels.h 392949 
>   /trunk/main/bridging.c 392949 
>   /trunk/main/channel.c 392949 
>   /trunk/main/channel_internal_api.c 392949 
>   /trunk/main/cli.c 392949 
>   /trunk/main/manager.c 392949 
>   /trunk/main/manager_bridging.c 392949 
>   /trunk/main/manager_channels.c 392949 
>   /trunk/main/pbx.c 392949 
>   /trunk/main/stasis_channels.c 392949 
>   /trunk/res/res_agi.c 392949 
> 
> Diff: https://reviewboard.asterisk.org/r/2645/diff/
> 
> 
> Testing
> -------
> 
> Executed the changed CLI commands, AMI actions, and AGI commands and ensured that the output is as expected.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130627/8775f8d8/attachment.htm>