[asterisk-dev] [Code Review] 2636: bridging: COLP updates on push/pull

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2636/
-----------------------------------------------------------

(Updated June 26, 2013, 5:16 p.m.)


Review request for Asterisk Developers.


Changes
-------

Knowing when to update COLP is hard and voodoo. I suspect going down the path of trying to suppress redundant COLP updates throughout is... just... hard and I'm not a huge fan of requiring users of bridging to know when they should.

This patch doesn't attempt to stop internally queueing up COLP updates. It errs on the side of "better safe than sorry" so legit COLP updates aren't prevented. What it also does is prevent redundant updates from reaching the device when in the bridging core. It compares the current connected line and if it is unchanged just drops the update. This *could* be placed into ast_indicate_data to make this globally done if we wanted.

This should ensure that COLP is updated appropriately.


Bugs: ASTERISK-21829
    https://issues.asterisk.org/jira/browse/ASTERISK-21829


Repository: Asterisk


Description
-------

The attached change adds COLP updates on bridging push/pull operations and passes information down so it can do it semi-intelligently (ie: only when it really should).

Old code which is no longer required has also been removed.


Diffs (updated)
-----

  /trunk/include/asterisk/channel.h 392646 
  /trunk/main/bridging.c 392646 
  /trunk/main/channel.c 392646 

Diff: https://reviewboard.asterisk.org/r/2636/diff/


Testing
-------

Tested the various scenarios to make sure that connected line information is updated when it should be (and not more than it needs to be).

Calling, transfers, etc.


Thanks,

Joshua Colp

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130626/28596c04/attachment.htm>