[asterisk-dev] [Code Review] 2573: res_parking: Recreate the 'Park' manager action in the new parking system

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2573/#review8954
-----------------------------------------------------------

Ship it!



/trunk/res/parking/parking_manager.c
<https://reviewboard.asterisk.org/r/2573/#comment17615>

    You can remove the TODO


- Matt Jordan


On June 21, 2013, 6:45 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2573/
> -----------------------------------------------------------
> 
> (Updated June 21, 2013, 6:45 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: ASTERISK-21641
>     https://issues.asterisk.org/jira/browse/ASTERISK-21641
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This patch gets the 'Park' manager action back up and working. It supports all the arguments to the old park manager action and seems to work in the same way.
> This patch also fixes an issue with the 'Bridge' manager action where channels yanked from two party bridges would leave the bridge up in spite of there being only one channel in the bridge at that point.
> 
> 
> Diffs
> -----
> 
>   /trunk/res/parking/parking_controller.c 392389 
>   /trunk/res/parking/parking_bridge_features.c 392389 
>   /trunk/res/parking/parking_bridge.c 392389 
>   /trunk/res/parking/parking_applications.c 392389 
>   /trunk/main/features.c 392389 
>   /trunk/main/bridging.c 392389 
>   /trunk/include/asterisk/features.h 392389 
>   /trunk/CHANGES 392389 
>   /trunk/res/parking/parking_manager.c 392389 
>   /trunk/res/parking/res_parking.h 392389 
> 
> Diff: https://reviewboard.asterisk.org/r/2573/diff/
> 
> 
> Testing
> -------
> 
> Pulled channels from bridged and unbridged calls with the 'Park' and made sure the channel on the other end got torn down in each case. I did similar stuff with the 'Bridge' command.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130624/792c091f/attachment.htm>