[asterisk-dev] [Code Review] 2620: bridge features: Make one touch Monitor and MixMonitor into bridge features

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2620/#review8934
-----------------------------------------------------------



/trunk/bridges/bridge_builtin_features.c
<https://reviewboard.asterisk.org/r/2620/#comment17583>

    This operation is performed in several places with the channel involved varying and slight syntactic/semantic differences.  It should probably be a function for consistency and maintainability.



/trunk/include/asterisk/mixmonitor.h
<https://reviewboard.asterisk.org/r/2620/#comment17584>

    This parameter name doesn't match the actual parameter name.



/trunk/include/asterisk/mixmonitor.h
<https://reviewboard.asterisk.org/r/2620/#comment17585>

    This needs more \retval.



/trunk/main/features_config.c
<https://reviewboard.asterisk.org/r/2620/#comment17586>

    Since this can't have documentation until https://reviewboard.asterisk.org/r/2616/ goes in, I'd add a BUGBUG here to fill in documentation later (or add documentation to this review when that gets committed now that it has a ship it).


- opticron


On June 18, 2013, 2:39 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2620/
> -----------------------------------------------------------
> 
> (Updated June 18, 2013, 2:39 p.m.)
> 
> 
> Review request for Asterisk Developers, Matt Jordan and rmudgett.
> 
> 
> Bugs: asterisk-21553
>     https://issues.asterisk.org/jira/browse/asterisk-21553
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Adds Monitor and MixMonitor as bridge features.  In order to avoid using PBX execution and autoservice, I added some additional API for MixMonitor provided through loadable function callbacks provided by app_mixmonitor.
> 
> In order to make One Touch MixMonitor behave more like its Monitor equivalent, I went ahead and added a couple channel variables for playing start and stop recording sounds (TOUCH_MIXMONITOR_MESSAGE_START and TOUCH_MIXMONITOR_MESSAGE_STOP)
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 391828 
>   /trunk/apps/app_mixmonitor.c 391828 
>   /trunk/bridges/bridge_builtin_features.c 391828 
>   /trunk/configs/features.conf.sample 391828 
>   /trunk/include/asterisk/features_config.h 391828 
>   /trunk/include/asterisk/mixmonitor.h PRE-CREATION 
>   /trunk/main/features_config.c 391828 
>   /trunk/main/mixmonitor.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2620/diff/
> 
> 
> Testing
> -------
> 
> Tried both Monitor and MixMonitor with various channel variables set for filename/format and start/stop sounds. They appear to be working as one would expect.
> Also checked the behavior of MixMonitor with app_mixmonitor loaded and unloaded. As expected, it is rejected smoothly when MixMonitor is not loaded.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130621/1d024bec/attachment-0001.htm>