[asterisk-dev] [Code Review] 2634: Implement ARI /channels dial.

[Jason Parker]

> On June 20, 2013, 1:02 p.m., Joshua Colp wrote:
> > /trunk/res/stasis/control.c, line 116
> > <https://reviewboard.asterisk.org/r/2634/diff/1/?file=39877#file39877line116>
> >
> >     There should probably be some kind of timeout here, or else it's up to the dialed target to have one (or reject the call).
> >     
> >     As well - is blocking until that occurs (answered or otherwise) really a good idea here?

Timeout added.

As far as I understand it, there's nothing being blocked here, as the command is being run async.


- Jason


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2634/#review8921
-----------------------------------------------------------


On June 19, 2013, 8:57 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2634/
> -----------------------------------------------------------
> 
> (Updated June 19, 2013, 8:57 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21620
>     https://issues.asterisk.org/jira/browse/ASTERISK-21620
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Implement the dial action on channels.  This creates a new outbound leg, which upon answer, gets bridged with an existing channel sitting in Stasis.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/stasis_app.h 392277 
>   /trunk/res/stasis/control.c 392277 
>   /trunk/res/stasis_http/resource_channels.c 392277 
> 
> Diff: https://reviewboard.asterisk.org/r/2634/diff/
> 
> 
> Testing
> -------
> 
> The bridge gets created.  The channels can talk to each other.  The bridge disappears once the caller hangs up.  The caller remains in Stasis and can still be acted upon.
> 
> 
> Thanks,
> 
> Jason Parker
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130620/addac76b/attachment.htm>