[asterisk-dev] [Code Review] 2572: Stasis-HTTP: Flesh out bridging capabilities

[Alec Davis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2572/#review8867
-----------------------------------------------------------


minor style deviations.
Exit early on error, continue to end is OK.


trunk/res/stasis_http/resource_bridges.c
<https://reviewboard.asterisk.org/r/2572/#comment17416>

    Don't we normally return early if we have an error?
    
    just like you do in stasis_http_new_bridge()
    
      if ..remove_channel {
        .. 500, internal error...
        return;
      }
      stasis_http_response_no_content(response);
    }
    



trunk/res/stasis_http/resource_bridges.c
<https://reviewboard.asterisk.org/r/2572/#comment17415>

    thus this could be:
    
    if (!snapshot) {
      .. 404, "Not Found...
      return;
    }
    ...response_ok...


- Alec Davis


On June 7, 2013, 8:10 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2572/
> -----------------------------------------------------------
> 
> (Updated June 7, 2013, 8:10 p.m.)
> 
> 
> Review request for Asterisk Developers and David Lee.
> 
> 
> Bugs: ASTERISK-21621, ASTERISK-21622, ASTERISK-21623, ASTERISK-21624, ASTERISK-21625, ASTERISK-21626, and ASTERISK-21711
>     https://issues.asterisk.org/jira/browse/ASTERISK-21621
>     https://issues.asterisk.org/jira/browse/ASTERISK-21622
>     https://issues.asterisk.org/jira/browse/ASTERISK-21623
>     https://issues.asterisk.org/jira/browse/ASTERISK-21624
>     https://issues.asterisk.org/jira/browse/ASTERISK-21625
>     https://issues.asterisk.org/jira/browse/ASTERISK-21626
>     https://issues.asterisk.org/jira/browse/ASTERISK-21711
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This adds support for Stasis applications to receive bridge-related messages when the application shows interest in a given bridge.
> 
> To supplement this work and test it, this also adds support for the following bridge-related Stasis-HTTP functionality:
> * GET stasis/bridges
> * GET stasis/bridges/{bridgeId}
> * POST stasis/bridges
> * DELETE stasis/bridges/{bridgeId}
> * POST stasis/bridges/{bridgeId}/addChannel
> * POST stasis/bridges/{bridgeId}/removeChannel
> 
> 
> Diffs
> -----
> 
>   trunk/include/asterisk/stasis_app.h 390901 
>   trunk/include/asterisk/stasis_bridging.h 390901 
>   trunk/main/stasis_bridging.c 390901 
>   trunk/res/res_stasis.c 390901 
>   trunk/res/res_stasis_bridge_add.c PRE-CREATION 
>   trunk/res/res_stasis_bridge_add.exports.in PRE-CREATION 
>   trunk/res/res_stasis_json_events.c 390901 
>   trunk/res/res_stasis_json_events.exports.in 390901 
>   trunk/res/stasis/app.h 390901 
>   trunk/res/stasis/app.c 390901 
>   trunk/res/stasis/control.c 390901 
>   trunk/res/stasis_http/resource_bridges.h 390901 
>   trunk/res/stasis_http/resource_bridges.c 390901 
>   trunk/res/stasis_json/resource_events.h 390901 
>   trunk/rest-api/api-docs/bridges.json 390901 
>   trunk/rest-api/api-docs/events.json 390901 
> 
> Diff: https://reviewboard.asterisk.org/r/2572/diff/
> 
> 
> Testing
> -------
> 
> Manual testing of the 6 implemented interfaces with curl and wscat to ensure bridge-related messages are delivered when appropriate.
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130608/11cac799/attachment.htm>