[asterisk-dev] [Code Review] 2570: Finish Gulp Connected Line Support

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2570/#review8860
-----------------------------------------------------------

Ship it!


Ship It!

- Mark Michelson


On May 29, 2013, 6:12 p.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2570/
> -----------------------------------------------------------
> 
> (Updated May 29, 2013, 6:12 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21258
>     https://issues.asterisk.org/jira/browse/ASTERISK-21258
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> This change implements handling of the connected line indication. This entails sending responses if possible, or sending requests (INVITE / UPDATE). The existing callerid code handles adding the information (and it does it marvelously).
> 
> 
> Diffs
> -----
> 
>   /team/group/pimp_my_sip/channels/chan_gulp.c 390033 
>   /team/group/pimp_my_sip/include/asterisk/res_sip.h 390033 
>   /team/group/pimp_my_sip/res/res_sip.c 390033 
>   /team/group/pimp_my_sip/res/res_sip/sip_configuration.c 390033 
>   /team/group/pimp_my_sip/res/res_sip_caller_id.c 390033 
> 
> Diff: https://reviewboard.asterisk.org/r/2570/diff/
> 
> 
> Testing
> -------
> 
> Tested various scenarios to ensure that the problem information is sent.
> 
> 
> Thanks,
> 
> Joshua Colp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130607/38d30e42/attachment.htm>