[asterisk-dev] [Code Review] 2597: Implement POST to channels, to originate a call.
opticron
reviewboard at asterisk.org
Thu Jun 6 08:38:39 CDT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2597/#review8821
-----------------------------------------------------------
/trunk/res/stasis_http/resource_channels.c
<https://reviewboard.asterisk.org/r/2597/#comment17351>
The documentation mentions nothing about this silently becoming a local channel dial when the tech is omitted from the endpoint.
/trunk/res/stasis_http/resource_channels.c
<https://reviewboard.asterisk.org/r/2597/#comment17352>
A failure to originate should be reported and a success should report the created channel. The 12th parameter will be filled in with the locked channel created if you provide it with a struct ast_channel**.
- opticron
On June 5, 2013, 2:10 p.m., Jason Parker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2597/
> -----------------------------------------------------------
>
> (Updated June 5, 2013, 2:10 p.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Bugs: ASTERISK-21617
> https://issues.asterisk.org/jira/browse/ASTERISK-21617
>
>
> Repository: Asterisk
>
>
> Description
> -------
>
> This doesn't support CallerID or codec selection, like the manager action. Should it?
>
>
> Diffs
> -----
>
> /trunk/res/res_stasis_http_channels.c 390539
> /trunk/res/stasis_http/resource_channels.h 390539
> /trunk/res/stasis_http/resource_channels.c 390539
> /trunk/res/stasis_json/resource_channels.h 390539
> /trunk/rest-api/api-docs/channels.json 390539
>
> Diff: https://reviewboard.asterisk.org/r/2597/diff/
>
>
> Testing
> -------
>
> Calls get made to the location you specify. The call gets put into the Stasis application when it gets answered.
>
>
> Thanks,
>
> Jason Parker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130606/c887d0e2/attachment.htm>
More information about the asterisk-dev
mailing list