[asterisk-dev] [Code Review] 2589: New SIP Channel Driver - add call pickup group configuration options

[Joshua Colp]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2589/#review8781
-----------------------------------------------------------



team/group/pimp_my_sip/res/res_sip/sip_configuration.c
<https://reviewboard.asterisk.org/r/2589/#comment17271>

    These handlers are very forgiving. The goal of sorcery and the underlying configuration framework is to not allow a configuration that is invalid, therefore I think these should be less forgiving - if a value is specified and not found... return an error.


- Joshua Colp


On June 4, 2013, 2:22 p.m., Kevin Harwell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2589/
> -----------------------------------------------------------
> 
> (Updated June 4, 2013, 2:22 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Bugs: ASTERISK-21505
>     https://issues.asterisk.org/jira/browse/ASTERISK-21505
> 
> 
> Repository: Asterisk
> 
> 
> Description
> -------
> 
> Added the ability to configure pick up groups automatically on a channel created for a chan_gulp endpoint. This includes:
> callgroup, pickupgroup, namedcallgroup, namedpickupgroup.
> 
> 
> Diffs
> -----
> 
>   team/group/pimp_my_sip/channels/chan_gulp.c 390389 
>   team/group/pimp_my_sip/include/asterisk/res_sip.h 390389 
>   team/group/pimp_my_sip/res/res_sip.c 390389 
>   team/group/pimp_my_sip/res/res_sip/sip_configuration.c 390389 
> 
> Diff: https://reviewboard.asterisk.org/r/2589/diff/
> 
> 
> Testing
> -------
> 
> Manually tested: Configured options on endpoints, called appropriate endpoint, and then picked up call from specified grouped endpoint.
> 
> 
> Thanks,
> 
> Kevin Harwell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130604/29c0f3e0/attachment-0001.htm>