[asterisk-dev] [Code Review] Adds variable length callinfo packets to skinny

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2290/#review7785
-----------------------------------------------------------

Ship it!


Other than the nitpick below, this looks good to go in.


/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2290/#comment14769>

    You may want to mask this instead of using multiplication and division so it's a little more clear that the two lower bits are being cleared.


- opticron


On Jan. 25, 2013, 1:16 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2290/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 1:16 p.m.)
> 
> 
> Review request for Asterisk Developers and Brad Latus.
> 
> 
> Summary
> -------
> 
> Add packet 0x014A (variable length call info messages) to skinny for newer firmware. Plenty of unknown information but includes the equivalent functionality as the fixed size callinfo packet already included.
> 
> Only send this packet if protocol reported is >= 17.
> 
> 
> This addresses bug ASTERISK-20965.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20965
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_skinny.c 380057 
> 
> Diff: https://reviewboard.asterisk.org/r/2290/diff
> 
> 
> Testing
> -------
> 
> Made in/out/missed calls on v17 phone, correct info displayed on call and on device call logs. Checked that the old callinfo is still used when protocol is <17.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130131/33eb1a30/attachment-0001.htm>