[asterisk-dev] [Code Review] Testsuite coverage for session-timers, uas, session-timers=originate

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2300/#review7780
-----------------------------------------------------------

Ship it!


Thank jeebus for the SIPpTestCase

- Mark


On Jan. 29, 2013, 10:52 a.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2300/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 10:52 a.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> While the fix for ASTERISK-20787 wasn't exactly rocket science, the
> code sorting through all the min's, max's and timers wasn't
> intuitively obvious. This test covers all of the typical combinations
> one would excpect for Min-SE and Session-Expires to make sure my fix
> didn't unduly break anything.
> 
> It's a big diff, but most of the test cases are identical, with
> differing values for Min-SE, Session-Expires, and expected results.
> 
> 
> This addresses bug ASTERISK-20787.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20787
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/channels/SIP/session_timers/tests.yaml 3624 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/large_minse_large_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/large_minse_large_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/large_minse_large_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/large_minse_large_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/large_minse_no_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/large_minse_no_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/large_minse_no_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/large_minse_no_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_large_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_large_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_large_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_large_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_medium_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_medium_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_medium_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_medium_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_no_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_no_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_no_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/medium_minse_no_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_large_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_large_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_large_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_large_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_medium_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_medium_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_medium_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_medium_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_no_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_no_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_no_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_no_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_small_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_small_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_small_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/no_minse_small_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_large_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_large_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_large_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_large_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_medium_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_medium_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_medium_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_medium_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_no_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_no_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_no_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_no_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_small_se/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_small_se/configs/ast1/sip.conf PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_small_se/sipp/uac-session-timer.xml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/small_minse_small_se/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/channels/SIP/session_timers/uas_originate/tests.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2300/diff
> 
> 
> Testing
> -------
> 
> Ran the tests with the fix in the related review[1], and they passed.
> 
>  [1]: https://reviewboard.asterisk.org/r/2299/
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130130/03d28b65/attachment.htm>