[asterisk-dev] [Code Review] Process session timers, even if Session-Expires header is missing

[Mark Michelson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2299/#review7779
-----------------------------------------------------------

Ship it!


Looks good to me!


/branches/1.8/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2299/#comment14760>

    You can use the MAX() macro for this:
    
    st_interval = MAX(dlg_max_se, uac_min_se);


- Mark


On Jan. 29, 2013, 11 a.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2299/
> -----------------------------------------------------------
> 
> (Updated Jan. 29, 2013, 11 a.m.)
> 
> 
> Review request for Asterisk Developers and Mark Michelson.
> 
> 
> Summary
> -------
> 
> Previously, Asterisk only processed session timer information if both
> the 'Supported: timer' and 'Session-Expires' headers were
> present. However, the Session-Expires header is optional. If we were
> to receive a request with a Min-SE greater than our configured
> session-expires, we would respond with a 'Session-Expires' header that
> was too small.
> 
> This patch cleans the situation up a bit, always processing timer
> information if the 'Supported: timer' header is present.
> 
> 
> This addresses bug ASTERISK-20787.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20787
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/chan_sip.c 380346 
> 
> Diff: https://reviewboard.asterisk.org/r/2299/diff
> 
> 
> Testing
> -------
> 
> Extensive testsuite tests. https://reviewboard.asterisk.org/r/2300
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130130/f12ab87c/attachment-0001.htm>