[asterisk-dev] [Code Review] Re-work building of pjproject

[wdoekes]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2292/#review7769
-----------------------------------------------------------


The `make -j` problems solved by the _cleantest_* workarounds seem to be resolved by this patch indeed.

But now `make distclean` is broken:
- distclean before configure doesn't work
- distclean after configure forces a configure of pjproject

You can live with both, but it's far from pretty.

- wdoekes


On Jan. 25, 2013, 1:40 p.m., Jason Parker wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2292/
> -----------------------------------------------------------
> 
> (Updated Jan. 25, 2013, 1:40 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This review depends on the changes from https://reviewboard.asterisk.org/r/2291/
> 
> 
> This changes the way we build pjproject.  We no longer need to execute the top-level 'all' target.  We can build individual libraries instead.
> 
> We should now be much more tolerant of build failures along the way.
> 
> Incidentally, in order to properly fix one of the major issues people were facing, I had to change our top-level Makefile to clean our own broken dependencies.  Targets that need configure to have been run should now actually require configure to have been run.
> 
> Also removes a few weird workarounds that got added along the way.
> 
> 
> This addresses bug ASTERISK-20815.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20815
> 
> 
> Diffs
> -----
> 
>   /branches/11/Makefile 380107 
>   /branches/11/res/Makefile 380107 
>   /branches/11/res/pjproject/aconfigure 380107 
>   /branches/11/res/pjproject/aconfigure.ac 380107 
>   /branches/11/res/pjproject/build/common.mak 380107 
>   /branches/11/res/pjproject/build/os-auto.mak.in 380107 
> 
> Diff: https://reviewboard.asterisk.org/r/2292/diff
> 
> 
> Testing
> -------
> 
> Many, many builds, in varying states of completeness and cleanliness.
> 
> 
> Thanks,
> 
> Jason
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130130/d3fd26cf/attachment.htm>