[asterisk-dev] [Code Review] Corrected crypto tag in SDP ANSWER for SRTP. (again)

[elguero]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2295/#review7748
-----------------------------------------------------------

Ship it!


Looks good to me except that one red spot.  I wasn't too crazy about the original patch that was attached to that issue and this patch is more thorough.


/branches/1.8/channels/sip/sdp_crypto.c
<https://reviewboard.asterisk.org/r/2295/#comment14742>

    redness


- elguero


On Jan. 28, 2013, 9:48 a.m., David Lee wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2295/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2013, 9:48 a.m.)
> 
> 
> Review request for Asterisk Developers and Matt Jordan.
> 
> 
> Summary
> -------
> 
> The original fix (r380043) for getting Asterisk to respond with the correct
> tag overlooked some corner cases, and the fact that the same code is in 1.8.
> 
> This patch moves the building of the crypto line out of
> sdp_crypto_process(). Instead, it merely copies the accepted tag. The call to
> sdp_crypto_offer() will build the crypto line in all cases now, using a tag of
> "1" in the case of sending offers.
> 
> 
> This addresses bug ASTERISK-20849.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20849
> 
> 
> Diffs
> -----
> 
>   /branches/1.8/channels/sip/sdp_crypto.c 380244 
> 
> Diff: https://reviewboard.asterisk.org/r/2295/diff
> 
> 
> Testing
> -------
> 
> Mades some calls using SRTP using a snom 820.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130128/fef06ce5/attachment-0001.htm>