[asterisk-dev] [Code Review]: Add queue_log_realtime_use_gmt option to logger.conf

[Paul Belanger]

> On Jan. 24, 2013, 11:22 a.m., jrose wrote:
> > This does make me wonder though... is there some reason we don't just want to handle this with a global configuration option to handle this rather than creating exceptions like this for individual loggers?

IKR?

If we were to spend some development cycles on this, I would say yes. Having the ability for all logging to use the same timezone configuration would make it easier to maintain.


- Paul


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2287/#review7728
-----------------------------------------------------------


On Jan. 23, 2013, 4:14 p.m., Russell Bryant wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2287/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2013, 4:14 p.m.)
> 
> 
> Review request for Asterisk Developers and Paul Belanger.
> 
> 
> Summary
> -------
> 
> Add an option that lets you specify that the timestamps going into the realtime queue log should be in GMT instead of local time.
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 380023 
>   /trunk/configs/logger.conf.sample 380023 
>   /trunk/main/logger.c 380023 
> 
> Diff: https://reviewboard.asterisk.org/r/2287/diff
> 
> 
> Testing
> -------
> 
> tested by Paul Belanger and confirmed to work as expected when on and off.
> 
> 
> Thanks,
> 
> Russell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130124/3236694a/attachment.htm>