[asterisk-dev] [Code Review] Add force dial keys to skinny

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2277/#review7720
-----------------------------------------------------------



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2277/#comment14711>

    "x, y"



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2277/#comment14712>

    I'd recommend breaking the default definition size calculation out into a temporary variable so that this is easier to read.



/trunk/channels/chan_skinny.c
<https://reviewboard.asterisk.org/r/2277/#comment14714>

    Index into the softkeymode array instead of using pointer arithmetic to make this more readable.


- opticron


On Jan. 20, 2013, 3:22 p.m., wedhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2277/
> -----------------------------------------------------------
> 
> (Updated Jan. 20, 2013, 3:22 p.m.)
> 
> 
> Review request for Asterisk Developers and Brad Latus.
> 
> 
> Summary
> -------
> 
> Adds a dial softkey when the device is in DAFD. The softkey is greyed (unusable) until a possible dialplan match is entered.
> 
> Code includes updating transmit_selectsoftkeys to allow the use of a button mask.
> 
> Also add option to use # or * as a dial now button.
> 
> 
> Diffs
> -----
> 
>   /trunk/channels/chan_skinny.c 379583 
>   /trunk/configs/skinny.conf.sample 379583 
> 
> Diff: https://reviewboard.asterisk.org/r/2277/diff
> 
> 
> Testing
> -------
> 
> Several calls, behaviour as expected.
> 
> 
> Thanks,
> 
> wedhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130124/c31ea40d/attachment.htm>