[asterisk-dev] [Code Review]: add queue pause device states for queue member/queues

[p_lindheimer]

> On Jan. 17, 2013, 9:37 a.m., Matt Jordan wrote:
> > I don't see any problem with this going into trunk.
> > 
> > As for Asterisk 11, the best approach is probably to see if anyone has any objections on the asterisk-dev list (which this review will go out to, but sometimes people don't read all of the code reviews).

I understand this is 'a feature request' which we shy away from in almost all cases for released branches. However, it's an example of an 'extremely low risk' change that one could call a grey area bug fix. State information is fundamental to Asterisk for features like this and not having such state information really does border on a grey are bug/feature. Maybe better stated as 'an oversight' for not being included in the first place. In comparison to the much more invasive feature done back in 1.4 adding device state information to queue members to get around a 'grey area bug' this one is much lower risk.

Also, if I understood correctly at Astricon, there is no more phones branch and new Digium phone features will be done in the main 11 branch. If that understanding is correct, this would definitely be a phone oriented feature. The fact that other phones beyond Digium can take advantage of it is not really relevant, and the super low invasiveness of the patch would make it much less risk then many other changes that have been made for Digium phones.

In any event, this is part of the Asterisk RPM with the FreePBX distro and is already being deployed by the thousands and quickly more. Our goal is to get it in the format that is approved by this board. Beyond that, I guess we can weigh the tradeoff between accepting it into 11 while 11 is very young or having a divergent feature that will eventually be on tens of thousands of Asterisk installations but inconsistent with the official branch.


- p_lindheimer


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2254/#review7678
-----------------------------------------------------------


On Dec. 27, 2012, 12:46 p.m., p_lindheimer wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2254/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2012, 12:46 p.m.)
> 
> 
> Review request for Asterisk Developers and p_lindheimer.
> 
> 
> Summary
> -------
> 
> Add a Queue Pause Device State that allows hints to be generated and thus useful BLF buttons on phones. The format is:
> 
> qpause:qname:agent
> 
> so an example hint that could be made from this, for agent 702 (Local) in queue 434 would look like this:
> 
> exten => *46*702*434,hint,qpause:434:Local/702 at from-queue/n
> 
> This has been implemented in FreePBX 2.11 (currently in beta) and is required for full functionality, it has been tested using version 11 and 10 and the patch is included on the version of Asterisk included in the FreePBX Distro for both versions 10 and 11.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 378206 
> 
> Diff: https://reviewboard.asterisk.org/r/2254/diff
> 
> 
> Testing
> -------
> 
> tested on latest versions 10 and 11 using FreePBX 2.11
> 
> 
> Thanks,
> 
> p_lindheimer
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130118/f32cbc07/attachment.htm>