[asterisk-dev] [Code Review] missing roundf causing asterisk to fail to compile
Matt Jordan
reviewboard at asterisk.org
Fri Jan 18 07:15:20 CST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2276/#review7692
-----------------------------------------------------------
Ship it!
/branches/1.8/main/strcompat.c
<https://reviewboard.asterisk.org/r/2276/#comment14646>
Nice.
- Matt
On Jan. 18, 2013, 5:37 a.m., wdoekes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2276/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 5:37 a.m.)
>
>
> Review request for Asterisk Developers.
>
>
> Summary
> -------
>
> > roundf is not available on some embedded systems and this is causing the compilation to fail.
>
> Fixed by adding a custom roundf().
>
>
> This addresses bug ASTERISK-16854.
> https://issues.asterisk.org/jira/browse/ASTERISK-16854
>
>
> Diffs
> -----
>
> /branches/1.8/configure.ac 379425
> /branches/1.8/include/asterisk/autoconfig.h.in 379425
> /branches/1.8/include/asterisk/compat.h 379425
> /branches/1.8/main/strcompat.c 379425
>
> Diff: https://reviewboard.asterisk.org/r/2276/diff
>
>
> Testing
> -------
>
> Compile-tested by renaming stuff to roundf2. It compiles.
>
>
> Thanks,
>
> wdoekes
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130118/21a76e6e/attachment.htm>
More information about the asterisk-dev
mailing list