[asterisk-dev] [Code Review] tests/bridge: Add a bridge test for the call parking feature

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2273/#review7685
-----------------------------------------------------------

Ship it!


Looks good to me other than the two minor things below.


/asterisk/trunk/tests/bridge/parkcall/Executioner.py
<https://reviewboard.asterisk.org/r/2273/#comment14644>

    Unused.



/asterisk/trunk/tests/bridge/parkcall/Executioner.py
<https://reviewboard.asterisk.org/r/2273/#comment14643>

    Unused.


- opticron


On Jan. 10, 2013, 3:54 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2273/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2013, 3:54 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and kmoore.
> 
> 
> Summary
> -------
> 
> This test detects the parking feature with the usual method for bridge tests.  In addition it has some extra functionality through a module I called the Executor which is responsible for killing parked calls once the other associated channels have hung up. CEL logging isn't checked because zombies are frustrating and you never know if they will die before or after the channel doing the parking (for each call there are three channels, those being the parker who dies upon parking, the parkee who should survive until the end of the test, and the zombie of the parkee who will die around the same time as the parker which is where the complications come from).  CDR logging is checked like with many of the other bridge tests.
> 
> 
> This addresses bug SWP-4716.
>     https://issues.asterisk.org/jira/browse/SWP-4716
> 
> 
> Diffs
> -----
> 
>   /asterisk/trunk/tests/bridge/parkcall/Executioner.py PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/trunk/tests/bridge/parkcall/test-config.yaml PRE-CREATION 
>   /asterisk/trunk/tests/bridge/tests.yaml 3582 
> 
> Diff: https://reviewboard.asterisk.org/r/2273/diff
> 
> 
> Testing
> -------
> 
> I checked that the test doesn't fail regardless of hangup order for the zombie and the parker and that the events being sent to the CEL while I was testing were at least consistent among individual tests for the two possible hangup orders. I also checked the logs to make sure that things were sensible for call parking.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130117/0dc3e418/attachment.htm>