[asterisk-dev] [Code Review] Add tests for Playback and ControlPlayback applications, with AMI manipulation via ControlPlayback action

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2270/#review7680
-----------------------------------------------------------

Ship it!


The incorrect summaries were the only things I found.  This is ready to go!

- opticron


On Jan. 17, 2013, 10:18 a.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2270/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2013, 10:18 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds the following tests for https://reviewboard.asterisk.org/r/2265/:
> * ControlPlayback application
> ** Test rewind, initiated by a user (with default and non-default values) and by an AMI connection
> ** Test fast forward, initiated by a user (with default and non-default values) and by an AMI connection
> ** Test restart, initiated by a user and AMI connection
> ** Test stop, initiated by a user and AMI connection
> ** Test pause, where the playback is both paused and unpaused, initiated by a user and AMI connection
> ** Test a (very) nominal playback
> 
> * Playback application
> ** Test rewind, initiated by an AMI connection
> ** Test fast forward, initiated by an AMI connection
> ** Test a stopped playback caused by restart, initiated by an AMI connection
> ** Test a stopped playback caused by stop, initiated by a an AMI connection
> ** Test a stopped playback caused by pause, initiated by an AMI connection
> ** Test a (very) nominal playback
> 
> As an added bonus: also a test that verifies AsyncAGI's 'break' command, namely that it actually breaks AsyncAGI.
> 
> 
> This addresses bug ASTERISK-20882.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20882
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/mjordan/longcat/configs/manager.conf 3600 
>   /asterisk/team/mjordan/longcat/lib/python/asterisk/SimpleTestCase.py 3600 
>   /asterisk/team/mjordan/longcat/lib/python/asterisk/apptest.py 3600 
>   /asterisk/team/mjordan/longcat/lib/python/asterisk/asterisk.py 3600 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_forward/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_forward/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_pause/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_pause/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_restart/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_restart/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_reverse/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_reverse/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_stop/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_stop/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/nominal/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/tests.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/nominal/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_forward/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_forward/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_pause/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_pause/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_restart/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_restart/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_reverse/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_reverse/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_stop/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_stop/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/tests.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/tests.yaml 3600 
>   /asterisk/team/mjordan/longcat/tests/asyncagi/asyncagi_break/asyncagi_break.py PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/asyncagi/asyncagi_break/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/asyncagi/asyncagi_break/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/asyncagi/tests.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/tests.yaml 3600 
> 
> Diff: https://reviewboard.asterisk.org/r/2270/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130117/6a07ca21/attachment.htm>