[asterisk-dev] [Code Review]: Add tests for Playback and ControlPlayback applications, with AMI manipulation via ControlPlayback action

[opticron]

> On Jan. 17, 2013, 8:53 a.m., opticron wrote:
> > /asterisk/team/mjordan/longcat/tests/tests.yaml, line 19
> > <https://reviewboard.asterisk.org/r/2270/diff/1/?file=32746#file32746line19>
> >
> >     Ditto.
> 
> Matt Jordan wrote:
>     See previous.
>     
>     Why did it get bundled with this set of tests? Because originally all of this was going to be done with AsyncAGI, until Richard pointed out that it should just be an AMI command. Since I'd already written the AsyncAGI break test, I left it in the branch and included it with the rest of tests.
>     
>     I can break it out into a separate review, but the AsyncAGI break test is fairly trivial.

That's not necessary, I just missed the entire second page of diffs.  They should be fine going in together.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2270/#review7672
-----------------------------------------------------------


On Jan. 8, 2013, 3:29 p.m., Matt Jordan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2270/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2013, 3:29 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This adds the following tests for https://reviewboard.asterisk.org/r/2265/:
> * ControlPlayback application
> ** Test rewind, initiated by a user (with default and non-default values) and by an AMI connection
> ** Test fast forward, initiated by a user (with default and non-default values) and by an AMI connection
> ** Test restart, initiated by a user and AMI connection
> ** Test stop, initiated by a user and AMI connection
> ** Test pause, where the playback is both paused and unpaused, initiated by a user and AMI connection
> ** Test a (very) nominal playback
> 
> * Playback application
> ** Test rewind, initiated by an AMI connection
> ** Test fast forward, initiated by an AMI connection
> ** Test a stopped playback caused by restart, initiated by an AMI connection
> ** Test a stopped playback caused by stop, initiated by a an AMI connection
> ** Test a stopped playback caused by pause, initiated by an AMI connection
> ** Test a (very) nominal playback
> 
> As an added bonus: also a test that verifies AsyncAGI's 'break' command, namely that it actually breaks AsyncAGI.
> 
> 
> This addresses bug ASTERISK-20882.
>     https://issues.asterisk.org/jira/browse/ASTERISK-20882
> 
> 
> Diffs
> -----
> 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/nominal/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_stop/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_stop/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_reverse/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_reverse/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_restart/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_restart/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_pause/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_pause/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/configs/manager.conf 3600 
>   /asterisk/team/mjordan/longcat/lib/python/asterisk/SimpleTestCase.py 3600 
>   /asterisk/team/mjordan/longcat/lib/python/asterisk/apptest.py 3600 
>   /asterisk/team/mjordan/longcat/lib/python/asterisk/asterisk.py 3600 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_forward/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/control_forward/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/control_playback/tests.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/nominal/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/nominal/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_forward/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_forward/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_pause/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_pause/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_restart/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_restart/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_reverse/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_reverse/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_stop/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/remote_stop/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/playback/tests.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/apps/tests.yaml 3600 
>   /asterisk/team/mjordan/longcat/tests/asyncagi/asyncagi_break/asyncagi_break.py PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/asyncagi/asyncagi_break/configs/ast1/extensions.conf PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/asyncagi/asyncagi_break/test-config.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/asyncagi/tests.yaml PRE-CREATION 
>   /asterisk/team/mjordan/longcat/tests/tests.yaml 3600 
> 
> Diff: https://reviewboard.asterisk.org/r/2270/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Matt
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130117/01e89304/attachment.htm>