[asterisk-dev] [Code Review] Sorcery Data Access Abstraction Layer

[David Lee]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2259/#review7654
-----------------------------------------------------------


Okay; I got about 1/3 of the way through the unit tests and glazed over. I'll get back to this later. For now, a few comments about the API.


/trunk/include/asterisk/sorcery.h
<https://reviewboard.asterisk.org/r/2259/#comment14570>

    Happy new year!



/trunk/include/asterisk/sorcery.h
<https://reviewboard.asterisk.org/r/2259/#comment14571>

    Why the split between the create and alloc calls?



/trunk/include/asterisk/sorcery.h
<https://reviewboard.asterisk.org/r/2259/#comment14582>

    Interesting choice to have wizards defined per-object-type. Why not per-sorcery.



/trunk/include/asterisk/sorcery.h
<https://reviewboard.asterisk.org/r/2259/#comment14574>

    Create, save or persist? It's not clear what this function is doing.


- David


On Jan. 9, 2013, 10:29 a.m., jcolp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2259/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2013, 10:29 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Sorcery is a new API which provides a generic data access/persistence mechanism. A user of this API defines their objects with some special sorcery specific contents. The object types themselves and the fields within the objects are then registered with sorcery. Operations can then occur to create, retrieve, update, or delete objects. There's also other aspects present such as configuration for mapping object types to different persistence mechanisms (with the current one available being in-memory). Other operations also exist which allow objects to be copied and diffed.
> 
> * I will run whitespace-cleanup on this :P red blobs will be gone.
> 
> 
> Diffs
> -----
> 
>   /trunk/tests/test_sorcery.c PRE-CREATION 
>   /trunk/res/res_sorcery_memory.c PRE-CREATION 
>   /trunk/res/res_sorcery_config.c PRE-CREATION 
>   /trunk/main/asterisk.c 378717 
>   /trunk/main/sorcery.c PRE-CREATION 
>   /trunk/configs/test_sorcery.conf.sample PRE-CREATION 
>   /trunk/include/asterisk/sorcery.h PRE-CREATION 
>   /trunk/configs/sorcery.conf.sample PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2259/diff
> 
> 
> Testing
> -------
> 
> Ran unit tests, confirmed they all passed and made changes to ensure the tests are valid.
> 
> 
> Thanks,
> 
> jcolp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130110/5e2e5215/attachment.htm>