[asterisk-dev] [Code Review] Play periodic prompts for first call in a call queue

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2263/#review7634
-----------------------------------------------------------

Ship it!


Paul's doxygen comment not withstanding, this looks good to go. Personally, this feels more like a bug than anything else, so I'd be fine with it going into 1.8+.

- Matt


On Jan. 7, 2013, 8 a.m., Olle E Johansson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2263/
> -----------------------------------------------------------
> 
> (Updated Jan. 7, 2013, 8 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> A call in the first position in the queue doesn't get maintained with prompts if a queue has periodic announcements. This small patch fixes that issue. 
> 
> Whether or not it can be seen as a bug is a separate discussion, but we need it in trunk at least.
> 
> 
> Diffs
> -----
> 
>   /trunk/apps/app_queue.c 378644 
> 
> Diff: https://reviewboard.asterisk.org/r/2263/diff
> 
> 
> Testing
> -------
> 
> Put myself in a call queue for 20 minutes. Heard Allison and a lot of brain-washing-stupid musiconhold music. Everything worked just fine.
> 
> 
> Thanks,
> 
> Olle E
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130108/42ec8865/attachment.htm>