[asterisk-dev] [Code Review]: Sorcery Data Access Abstraction Layer

[jcolp]

> On Jan. 4, 2013, 3:47 p.m., opticron wrote:
> > /trunk/main/sorcery.c, line 367
> > <https://reviewboard.asterisk.org/r/2259/diff/3/?file=32538#file32538line367>
> >
> >     This statement doesn't need to be in a conditional.

Fixed.


> On Jan. 4, 2013, 3:47 p.m., opticron wrote:
> > /trunk/configs/sorcery.conf.sample, line 6
> > <https://reviewboard.asterisk.org/r/2259/diff/3/?file=32535#file32535line6>
> >
> >     Remove "object" from this sentence.

Fixed.


> On Jan. 4, 2013, 3:47 p.m., opticron wrote:
> > /trunk/main/sorcery.c, line 315
> > <https://reviewboard.asterisk.org/r/2259/diff/3/?file=32538#file32538line315>
> >
> >     This statement doesn't need to be in a conditional.

Fixed.


> On Jan. 4, 2013, 3:47 p.m., opticron wrote:
> > /trunk/include/asterisk/sorcery.h, line 234
> > <https://reviewboard.asterisk.org/r/2259/diff/3/?file=32536#file32536line234>
> >
> >     Why wouldn't the module just be set in the ast_sorcery_wizard structure before calling this function?

I've turned this into a macro which automatically does the right thing.


- jcolp


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2259/#review7613
-----------------------------------------------------------


On Jan. 4, 2013, 6:28 a.m., jcolp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2259/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2013, 6:28 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Sorcery is a new API which provides a generic data access/persistence mechanism. A user of this API defines their objects with some special sorcery specific contents. The object types themselves and the fields within the objects are then registered with sorcery. Operations can then occur to create, retrieve, update, or delete objects. There's also other aspects present such as configuration for mapping object types to different persistence mechanisms (with the current one available being in-memory). Other operations also exist which allow objects to be copied and diffed.
> 
> * I will run whitespace-cleanup on this :P red blobs will be gone.
> 
> 
> Diffs
> -----
> 
>   /trunk/configs/sorcery.conf.sample PRE-CREATION 
>   /trunk/include/asterisk/sorcery.h PRE-CREATION 
>   /trunk/main/asterisk.c 378411 
>   /trunk/main/sorcery.c PRE-CREATION 
>   /trunk/res/res_sorcery_memory.c PRE-CREATION 
>   /trunk/tests/test_sorcery.c PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2259/diff
> 
> 
> Testing
> -------
> 
> Ran unit tests, confirmed they all passed and made changes to ensure the tests are valid.
> 
> 
> Thanks,
> 
> jcolp
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130105/a9c58cdf/attachment-0001.htm>