[asterisk-dev] [Code Review] This patch adds externaddr per trunk

[opticron]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2345/#review7916
-----------------------------------------------------------



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2345/#comment15023>

    Red blob.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2345/#comment15027>

    The fact that 'externaddr' is a new setting does not need to be explained and will quickly be incorrect if committed.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2345/#comment15024>

    Red blob.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2345/#comment15026>

    Remove this extra line.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2345/#comment15025>

    Red blob.



/trunk/channels/chan_sip.c
<https://reviewboard.asterisk.org/r/2345/#comment15028>

    Red blobs.


- opticron


On Feb. 22, 2013, 4:40 a.m., jozza wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2345/
> -----------------------------------------------------------
> 
> (Updated Feb. 22, 2013, 4:40 a.m.)
> 
> 
> Review request for Asterisk Developers and leifmadsen.
> 
> 
> Summary
> -------
> 
> Read latest comments on bugs page
> 
> 
> This addresses bug https://issues.asterisk.org/jira/browse/ASTERISK-18643.
>     https://issues.asterisk.org/jira/browse/https://issues.asterisk.org/jira/browse/ASTERISK-18643
> 
> 
> Diffs
> -----
> 
>   /trunk/CHANGES 380806 
>   /trunk/channels/chan_sip.c 380806 
>   /trunk/channels/sip/include/sip.h 380806 
> 
> Diff: https://reviewboard.asterisk.org/r/2345/diff
> 
> 
> Testing
> -------
> 
> tested for 1.6 works fine, untested for trunk, should work
> 
> 
> Thanks,
> 
> jozza
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130222/ab379ff8/attachment.htm>