[asterisk-dev] [Code Review] bridging: Holding bridge technology and app_bridgewait

[rmudgett]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2342/#review7906
-----------------------------------------------------------



/team/jrose/bridge_projects/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2342/#comment14999>

    Application to place the channel into a holding bridge.



/team/jrose/bridge_projects/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2342/#comment15001>

    1 << 0
    1 << 1
    1 << 2



/team/jrose/bridge_projects/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2342/#comment15005>

    This does not need to be initialized.  It could even be eliminated entirely.



/team/jrose/bridge_projects/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2342/#comment15004>

    This block can be done first thing so you don't have to call ast_bridge_features_cleanup() before returning.



/team/jrose/bridge_projects/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2342/#comment15002>

    Could not create holding bridge for '%s'.
    
    Include channel name.



/team/jrose/bridge_projects/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2342/#comment15003>

    You can use ast_check_hangup_locked() instead to figure out the return value.
    
    return ast_check_hangup_locked(chan) ? -1 : 0;



/team/jrose/bridge_projects/apps/app_bridgewait.c
<https://reviewboard.asterisk.org/r/2342/#comment15000>

    Place the channel into a holding bridge application.



/team/jrose/bridge_projects/bridges/bridge_holding.c
<https://reviewboard.asterisk.org/r/2342/#comment14997>

    This callback is not required to exist unlike the write callback which must exist.



/team/jrose/bridge_projects/bridges/bridge_holding.c
<https://reviewboard.asterisk.org/r/2342/#comment14998>

    Holding bridge module


- rmudgett


On Feb. 21, 2013, 12:01 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2342/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 12:01 p.m.)
> 
> 
> Review request for Asterisk Developers and rmudgett.
> 
> 
> Summary
> -------
> 
> This fulfills some of the preliminary goals needed for refactoring parking. First I've created a bridging technology that is very minimalistic in nature (it doesn't do any actual communication between channels on a given holding bridge) for storing parked calls. This technology will also likely be used for queues and maybe some other stuff later on. Second, I've created an application that holds a reference to a single holding bridge which can place channels into the holding bridge.  It includes some options for playing music on hold, ringing, and for breaking the bridge (such as in a queue/park timeout) after a certain amount of time.
> 
> I haven't implemented any kind of silence generation since I'm not sure it would be necessary and I'm also just plain not sure how to do that at the moment.
> 
> 
> This addresses bug ASTERISK-21059.
>     https://issues.asterisk.org/jira/browse/ASTERISK-21059
> 
> 
> Diffs
> -----
> 
>   /team/jrose/bridge_projects/apps/app_bridgewait.c PRE-CREATION 
>   /team/jrose/bridge_projects/bridges/bridge_holding.c PRE-CREATION 
>   /team/jrose/bridge_projects/include/asterisk/bridging.h 381803 
> 
> Diff: https://reviewboard.asterisk.org/r/2342/diff
> 
> 
> Testing
> -------
> 
> So far I've just been testing the app against the options and seeing how the channels work in bridges. Everything seems to work as expected.
> 
> exten => 40,1,Answer()
> exten => 40,n,BridgeWait(mS(8))
> exten => 40,n,Playback(tt-weasels)
> 
> exten => 41,1,Answer()
> exten => 41,n,BridgeWait(rS(10))
> exten => 41,n,Playback(queue-youarenext)
> 
> exten => 42,1,Answer()
> exten => 42,n,BridgeWait()
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130221/35ec05b5/attachment-0001.htm>