[asterisk-dev] [Code Review]: Add bridge tests to check transfer capabilites

[opticron]

> On Feb. 19, 2013, 3:37 p.m., jrose wrote:
> > Hmmmmm. 4 calls in the bridge module. 3 CDRs and 3 LINKEDID_END events... I think you can guess what I'm getting at.
> > 
> > I'm still getting a reactor timeout and we still aren't getting to the fourth call. That said, the test passes on my box now, but this is still incorrect behavior because the bridge module is failing. Clearly the bridge module needs failure tokens because it can fail on timeout like it has been and it will never report the error.  Then when the rest of the modules report success (or at least one of them reports success and none of the others report failure) the test appears to pass even though it critically failed like this.
> 
> jrose wrote:
>     Also, for the record...
>     
>     [Feb 19 15:29:09] WARNING[24048]: TestCase:363 __reactor_timeout: Reactor timeout: '30' seconds
>     [Feb 19 15:29:14] ERROR[24048]: AMI:264 dispatchEvent: Exception in event handler <bound method BridgeTestCase.hangup_callback of <BridgeTestCase.BridgeTestCase object at 0x9310cac>> on event {'connectedlinenum': '4321', 'cause-txt': 'Normal Clearing', 'accountcode': '', 'calleridnum': '1234', 'connectedlinename': 'Bob', 'uniqueid': '1361309314.4', 'calleridname': 'Alice', 'privilege': 'call,all', 'cause': '16', 'event': 'Hangup', 'channel': 'SIP/alice-00000004'}: Tried to cancel an already-called event.
>     [Feb 19 15:29:15] WARNING[24048]: astcsv:193 match: More than one CSV permutation results in success
>     <?xml version="1.0" encoding="utf-8"?>
>     <testsuite errors="0" failures="0" name="AsteriskTestSuite" tests="1" time="181.65">
>       <testcase name="tests/bridge/transfer_capabilities" time="181.65"/>
>     </testsuite>
>

I must have missed the reactor timeout amidst the jumble of text resulting from the failed cancellation of a deferred (which seems to be a normal occurrance at this point).  Fixed.


- opticron


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2268/#review7897
-----------------------------------------------------------


On Feb. 19, 2013, 2:40 p.m., opticron wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2268/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2013, 2:40 p.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> Test blind and attended transfers from Alice and Bob to ensure that the "T" and "t" options allow the correct parties to perform transfers when used from the Dial application and from BRIDGE_FEATURES.
> 
> 
> This addresses bug SWP-5268.
>     https://issues.asterisk.org/jira/browse/SWP-5268
> 
> 
> Diffs
> -----
> 
>   asterisk/trunk/lib/python/asterisk/BridgeTestCase.py 3642 
>   asterisk/trunk/tests/bridge/tests.yaml 3642 
>   asterisk/trunk/tests/bridge/transfer_capabilities/configs/ast1/extensions.conf PRE-CREATION 
>   asterisk/trunk/tests/bridge/transfer_capabilities/test-config.yaml PRE-CREATION 
> 
> Diff: https://reviewboard.asterisk.org/r/2268/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> opticron
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130220/74a2b564/attachment.htm>