[asterisk-dev] [Code Review] Disallow MoH upon hold option

[Kevin Harwell]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2336/
-----------------------------------------------------------

(Updated Feb. 19, 2013, 3:26 p.m.)


Review request for Asterisk Developers.


Changes
-------

The "discard_remote_hold_retrieval" option can now be specified under the peer or globally.


Summary
-------

A remote hold via SIP causes local music on hold.  Added a per peer option "discard_remote_hold_retrieval" (default "no") that if set will not trigger the music on hold event.


This addresses bug ABE-2899.
    https://issues.asterisk.org/jira/browse/ABE-2899


Diffs (updated)
-----

  /trunk/CHANGES 381793 
  /trunk/channels/chan_sip.c 381793 
  /trunk/channels/sip/include/sip.h 381793 

Diff: https://reviewboard.asterisk.org/r/2336/diff


Testing
-------

Set the discard_remote_hold_retrieval option for phone A, called phone B, and then had phone A place phone B on hold.  No music on hold was played.  Also wrote a test for the teststuite that runs through several scenarios and makes sure that no music on hold event is raised.


Thanks,

Kevin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130219/062310ed/attachment.htm>