[asterisk-dev] [Code Review] func_presencestate: Provide better documentation for the 'e' (encode base64) option [documentation only]

[Matt Jordan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2335/#review7890
-----------------------------------------------------------

Ship it!


- Matt


On Feb. 18, 2013, 12:07 p.m., jrose wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2335/
> -----------------------------------------------------------
> 
> (Updated Feb. 18, 2013, 12:07 p.m.)
> 
> 
> Review request for Asterisk Developers, Mark Michelson and Matt Jordan.
> 
> 
> Summary
> -------
> 
> The description for the 'e' option was poor and didn't explain at all what the behavior really was.
> 
> When using the write function with e, strings provided for subtype and message are expected to be base64 encoded and will be decoded for internal storage.
> When using the read function with e, the output will be encoded into base64 from whatever the current presence state is internally.
> 
> 
> Diffs
> -----
> 
>   /branches/11/funcs/func_presencestate.c 381640 
> 
> Diff: https://reviewboard.asterisk.org/r/2335/diff
> 
> 
> Testing
> -------
> 
> Checked how the function actually performs, made sure the documentation change appears appropriately formatted within Asterisk.
> 
> 
> Thanks,
> 
> jrose
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130218/17025095/attachment.htm>