[asterisk-dev] [Code Review]: Sorcery retrieve_by_regex support

[Joshua Colp]

> On Feb. 15, 2013, 6:40 a.m., wdoekes wrote:
> > /trunk/res/res_sorcery_config.c, line 217
> > <https://reviewboard.asterisk.org/r/2329/diff/1-2/?file=33448#file33448line217>
> >
> >     +1 to removing the ICASE,
> >     -1 to removing the EXTENDED.
> >     
> >     I think extended (or -- pretty compatible -- pcre) is the most commonly used form in various places: less chance of having to mold the string into something else before passing it on to new wizard backends.

Ultimately there will be a time where the underlying wizard can't support this and the implementation itself will have to do something to convert. We'll cross that bridge when we get to it.


- Joshua


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviewboard.asterisk.org/r/2329/#review7881
-----------------------------------------------------------


On Feb. 15, 2013, 6:44 a.m., Joshua Colp wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviewboard.asterisk.org/r/2329/
> -----------------------------------------------------------
> 
> (Updated Feb. 15, 2013, 6:44 a.m.)
> 
> 
> Review request for Asterisk Developers.
> 
> 
> Summary
> -------
> 
> This change adds a retrieve_by_regex API call to sorcery. It allows searching for multiple objects using a regular expression on the object identifier. This is useful if you have related objects and want to efficiently find them.
> 
> 
> Diffs
> -----
> 
>   /trunk/include/asterisk/sorcery.h 381525 
>   /trunk/main/sorcery.c 381525 
>   /trunk/res/res_sorcery_config.c 381525 
>   /trunk/res/res_sorcery_memory.c 381525 
>   /trunk/tests/test_sorcery.c 381525 
> 
> Diff: https://reviewboard.asterisk.org/r/2329/diff
> 
> 
> Testing
> -------
> 
> Ran unit test, confirmed happy.
> 
> 
> Thanks,
> 
> Joshua
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-dev/attachments/20130215/e88e3230/attachment.htm>